Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow "error" string as log level #1235

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Allow "error" string as log level #1235

merged 3 commits into from
Jun 23, 2023

Conversation

loqimean
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

anniel-stripe
anniel-stripe requested changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@anniel-stripe anniel-stripe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need LEVEL_ERROR as a level here - otherwise the library will throw an error if the user tries to set Stripe.log_level = Stripe::LEVEL_ERROR. The error message isn't quite correct though - it wasn't changed in #570 where we added the error level.

Right now we technically allow nil, "debug", "info", Stripe::LEVEL_INFO, Stripe::LEVEL_DEBUG, and Stripe::LEVEL_ERROR, but I think "error" should also be a valid value. If you'd like, could you update the string to level conversion and error message to allow for that?

lib/stripe/stripe_configuration.rb Show resolved Hide resolved
@anniel-stripe anniel-stripe merged commit 6dce6c1 into stripe:master Jun 23, 2023
@anniel-stripe anniel-stripe changed the title remove unnecessary log level from available Allow "error" string as log level Jun 23, 2023
@anniel-stripe anniel-stripe mentioned this pull request Jun 23, 2023
Merged
@loqimean loqimean deleted the patch-1 branch June 29, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anniel-stripe anniel-stripe anniel-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loqimean @CLAassistant @anniel-stripe